satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r606251255
########## File path: remote-storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCacheTest.java ########## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.log.remote.storage; + +import org.apache.kafka.common.TopicIdPartition; +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.common.Uuid; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; + +import java.util.Arrays; +import java.util.Collections; +import java.util.HashSet; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; + +public class RemoteLogMetadataCacheTest { + + private static final TopicIdPartition TP0 = new TopicIdPartition(Uuid.randomUuid(), + new TopicPartition("foo", 0)); + private static final int SEG_SIZE = 1024 * 1024; + private static final int BROKER_ID = 0; + + @Test + public void testCacheSegmentsWithDifferentStates() throws Exception { + RemoteLogMetadataCache cache = new RemoteLogMetadataCache(); + + // Add segments with different states and check cache.remoteLogSegmentMetadata(int leaderEpoch, long offset) + // cache.listRemoteLogSegments(int leaderEpoch), and cache.listAllRemoteLogSegments(). + + // ============================================================================================================= + // 1.Create a segment with state COPY_SEGMENT_STARTED, and check for searching that segment and listing the + // segments. + // ============================================================================================================== + Map<Integer, Long> seg0leaderEpochs = Collections.singletonMap(0, 0L); + RemoteLogSegmentId seg0Id = new RemoteLogSegmentId(TP0, Uuid.randomUuid()); + RemoteLogSegmentMetadata segCopyInProgress = new RemoteLogSegmentMetadata(seg0Id, 0L, 50L, -1L, BROKER_ID, + System.currentTimeMillis(), SEG_SIZE, seg0leaderEpochs); + cache.addToInProgress(segCopyInProgress); + + // This segment should not be available as the state is not reached to COPY_SEGMENT_FINISHED. + Optional<RemoteLogSegmentMetadata> seg0s0e0 = cache.remoteLogSegmentMetadata(0, 0); + Assertions.assertFalse(seg0s0e0.isPresent()); + + // cache.listRemoteLogSegments(0) should not contain the above segment, it will be empty. + Assertions.assertFalse(cache.listRemoteLogSegments(0).hasNext()); + // But cache.listRemoteLogSegments() should contain the above segment. + checkContainsAll(cache.listAllRemoteLogSegments(), Collections.singletonList(segCopyInProgress)); + + // ============================================================================================================= + // 2.Create a segment and move it to state COPY_SEGMENT_FINISHED. and check for searching that segment and + // listing the segments. + // ============================================================================================================== + Map<Integer, Long> seg1leaderEpochs = Collections.singletonMap(0, 101L); + RemoteLogSegmentId seg1Id = new RemoteLogSegmentId(TP0, Uuid.randomUuid()); + RemoteLogSegmentMetadata seg1 = new RemoteLogSegmentMetadata(seg1Id, 101L, 200L, -1L, BROKER_ID, + System.currentTimeMillis(), SEG_SIZE, seg1leaderEpochs); + cache.addToInProgress(seg1); + RemoteLogSegmentMetadataUpdate seg1Update = new RemoteLogSegmentMetadataUpdate(seg1Id, + System.currentTimeMillis(), RemoteLogSegmentState.COPY_SEGMENT_FINISHED, BROKER_ID); + cache.updateRemoteLogSegmentMetadata(seg1Update); + RemoteLogSegmentMetadata segCopyFinished = seg1.createRemoteLogSegmentWithUpdates(seg1Update); + + // Search should return the above segment. + Optional<RemoteLogSegmentMetadata> seg1S150 = cache.remoteLogSegmentMetadata(0, 150); + Assertions.assertEquals(seg1.createRemoteLogSegmentWithUpdates(seg1Update), seg1S150.orElse(null)); + + // cache.listRemoteLogSegments(0) should not contain the above segment. + checkContainsAll(cache.listRemoteLogSegments(0), Collections.singletonList(segCopyFinished)); + // But cache.listRemoteLogSegments() should contain both the segments. + checkContainsAll(cache.listAllRemoteLogSegments(), Arrays.asList(segCopyInProgress, segCopyFinished)); + + // ============================================================================================================= + // 3.Create a segment and move it to state DELETE_SEGMENT_STARTED, and check for searching that segment and + // listing the segments. + // ============================================================================================================== + Map<Integer, Long> seg2leaderEpochs = Collections.singletonMap(0, 201L); + RemoteLogSegmentId seg2Id = new RemoteLogSegmentId(TP0, Uuid.randomUuid()); + RemoteLogSegmentMetadata seg2 = new RemoteLogSegmentMetadata(seg2Id, 201L, 300L, -1L, BROKER_ID, + System.currentTimeMillis(), SEG_SIZE, seg2leaderEpochs); + cache.addToInProgress(seg2); + RemoteLogSegmentMetadataUpdate seg2Update = new RemoteLogSegmentMetadataUpdate(seg2Id, + System.currentTimeMillis(), RemoteLogSegmentState.DELETE_SEGMENT_STARTED, BROKER_ID); + cache.updateRemoteLogSegmentMetadata(seg2Update); + RemoteLogSegmentMetadata segDeleteStarted = seg2.createRemoteLogSegmentWithUpdates(seg2Update); + + // Search should return the above segment. + Optional<RemoteLogSegmentMetadata> seg2S250 = cache.remoteLogSegmentMetadata(0, 250); + Assertions.assertEquals(seg2.createRemoteLogSegmentWithUpdates(seg2Update), seg2S250.orElse(null)); + + // cache.listRemoteLogSegments(0) should contain the above segment. + checkContainsAll(cache.listRemoteLogSegments(0), Arrays.asList(segCopyFinished, segDeleteStarted)); + // But cache.listRemoteLogSegments() should contain all the segments. + checkContainsAll(cache.listAllRemoteLogSegments(), + Arrays.asList(segCopyInProgress, segCopyFinished, segDeleteStarted)); + + // ============================================================================================================= + // 4.Create a segment and move it to state DELETE_SEGMENT_FINISHED, and check for searching that segment and + // listing the segments. + // ============================================================================================================== + Map<Integer, Long> seg3leaderEpochs = Collections.singletonMap(0, 301L); + RemoteLogSegmentId seg3Id = new RemoteLogSegmentId(TP0, Uuid.randomUuid()); + RemoteLogSegmentMetadata seg3 = new RemoteLogSegmentMetadata(seg3Id, 301L, 400L, -1L, BROKER_ID, + System.currentTimeMillis(), SEG_SIZE, seg3leaderEpochs); + cache.addToInProgress(seg3); + RemoteLogSegmentMetadataUpdate seg3Update1 = new RemoteLogSegmentMetadataUpdate(seg3Id, + System.currentTimeMillis(), RemoteLogSegmentState.DELETE_SEGMENT_STARTED, BROKER_ID); + cache.updateRemoteLogSegmentMetadata(seg3Update1); + + // Search should return the above segment. + Optional<RemoteLogSegmentMetadata> seg3S350 = cache.remoteLogSegmentMetadata(0, 350); + Assertions.assertEquals(seg3.createRemoteLogSegmentWithUpdates(seg3Update1), seg3S350.orElse(null)); + + RemoteLogSegmentMetadataUpdate seg3Update2 = new RemoteLogSegmentMetadataUpdate(seg3Id, + System.currentTimeMillis(), RemoteLogSegmentState.DELETE_SEGMENT_FINISHED, BROKER_ID); + cache.updateRemoteLogSegmentMetadata(seg3Update2); + + // cache.listRemoteLogSegments(0) should not contain the above segment. + checkContainsAll(cache.listRemoteLogSegments(0), Arrays.asList(segCopyFinished, segDeleteStarted)); + // But cache.listRemoteLogSegments() should not contain both the segments as it should have been removed. + checkContainsAll(cache.listAllRemoteLogSegments(), + Arrays.asList(segCopyInProgress, segCopyFinished, segDeleteStarted)); + } + + private void checkContainsAll(Iterator<RemoteLogSegmentMetadata> allSegments, Review comment: Good catch. This is addressed in the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
