dengziming commented on a change in pull request #10393:
URL: https://github.com/apache/kafka/pull/10393#discussion_r606258483
##########
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##########
@@ -592,44 +592,17 @@ private VoteResponseData handleVoteRequest(
transitionToUnattached(candidateEpoch);
}
- final boolean voteGranted;
- if (quorum.isLeader()) {
- logger.debug("Rejecting vote request {} with epoch {} since we are
already leader on that epoch",
- request, candidateEpoch);
- voteGranted = false;
- } else if (quorum.isCandidate()) {
- logger.debug("Rejecting vote request {} with epoch {} since we are
already candidate on that epoch",
- request, candidateEpoch);
- voteGranted = false;
- } else if (quorum.isResigned()) {
- logger.debug("Rejecting vote request {} with epoch {} since we
have resigned as candidate/leader in this epoch",
- request, candidateEpoch);
- voteGranted = false;
- } else if (quorum.isFollower()) {
- FollowerState state = quorum.followerStateOrThrow();
- logger.debug("Rejecting vote request {} with epoch {} since we
already have a leader {} on that epoch",
- request, candidateEpoch, state.leaderId());
- voteGranted = false;
- } else if (quorum.isVoted()) {
- VotedState state = quorum.votedStateOrThrow();
- voteGranted = state.votedId() == candidateId;
-
- if (!voteGranted) {
- logger.debug("Rejecting vote request {} with epoch {} since we
already have voted for " +
- "another candidate {} on that epoch", request,
candidateEpoch, state.votedId());
- }
- } else if (quorum.isUnattached()) {
+ Supplier<Boolean> logComparator = () -> {
Review comment:
Compute this value in all cases and pass it through seems more clear
here.
##########
File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java
##########
@@ -304,6 +305,12 @@ public String toString() {
}
}
+ @Override
+ public boolean grantVote(int candidateId, Supplier<Boolean> logComparator)
{
+ log.debug("Rejecting vote request since we are already leader on that
epoch");
Review comment:
Good suggestions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
