ijuma commented on a change in pull request #10459:
URL: https://github.com/apache/kafka/pull/10459#discussion_r605722637
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1292,8 +1290,7 @@ object KafkaConfig {
.define(SaslLoginRefreshMinPeriodSecondsProp, SHORT,
Defaults.SaslLoginRefreshMinPeriodSeconds, MEDIUM,
SaslLoginRefreshMinPeriodSecondsDoc)
.define(SaslLoginRefreshBufferSecondsProp, SHORT,
Defaults.SaslLoginRefreshBufferSeconds, MEDIUM,
SaslLoginRefreshBufferSecondsDoc)
/** ********* Delegation Token Configuration ****************/
- .define(DelegationTokenSecretKeyAliasProp, PASSWORD, null, MEDIUM,
DelegationTokenSecretKeyAliasDoc)
- .define(DelegationTokenSecretKeyProp, PASSWORD, null, MEDIUM,
DelegationTokenSecretKeyDoc)
+ .define(DelegationTokenSecretKeyProp, PASSWORD, MEDIUM,
DelegationTokenSecretKeyDoc)
Review comment:
Will fix if we agree that this is a good idea. :) It's more aggressive
than I would usually recommend, so I'm looking for additional opinions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
