[
https://issues.apache.org/jira/browse/KAFKA-12602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314665#comment-17314665
]
John Roesler commented on KAFKA-12602:
--------------------------------------
Thanks for your kind offer, [~jmclean] !
I've gone through all the lib jars that we are shipping in our 2.8.0 binary
artifact, and done my best to put together a correct license file here:
[https://github.com/apache/kafka/pull/10474] . If you're able to review it, I
would greatly appreciate it.
Aside from the binary dependencies, I took a look at the source dependencies
that you listed in the mailing list:
1. ./clients/src/main/java/org/apache/kafka/common/utils/PureJavaCrc32C.java
2. ./streams/src/main/java/org/apache/kafka/streams/state/internals/Murmur3.java
3 ./tests/kafkatest/utils/util.py (and a couple of other files)
4 ./gradlew
The first two are licensed as Apache2 in their source locations, and they
contain what looks like correct copyright attributions in the files.
PureJavaCrc32C came from Hadoop and Murmur3 came from Hive. Given that this
code already belongs to the ASF, it doesn't seem like anything needs to be done
here. Am I looking at the situation wrong?
The last two were actually just mistakes. Those files had been placed in the
repo by a Confluent employee under the regular terms of the CLA, so they
shouldn't have had the extra copyright notice. They belong to the ASF now, and
there's no special license for them, except the Apache2 license that covers the
rest of the code in the repo. I fixed them already in the last PR.
Any feedback or guidance you're able to provide is greatly appreciated.
Thanks,
-John
> The LICENSE and NOTICE files don't list everything they should
> --------------------------------------------------------------
>
> Key: KAFKA-12602
> URL: https://issues.apache.org/jira/browse/KAFKA-12602
> Project: Kafka
> Issue Type: Bug
> Reporter: John Roesler
> Assignee: John Roesler
> Priority: Blocker
> Fix For: 2.8.0, 2.7.1, 2.6.2
>
>
> [~jmclean] raised this on the mailing list:
> [https://lists.apache.org/thread.html/r2df54c11c10d3d38443054998bc7dd92d34362641733c2fb7c579b50%40%3Cdev.kafka.apache.org%3E]
>
> We need to make the license file match what we are actually shipping in
> source and binary distributions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
