cmccabe commented on a change in pull request #10465: URL: https://github.com/apache/kafka/pull/10465#discussion_r608067488
########## File path: core/src/test/scala/unit/kafka/server/ControllerApisTest.scala ########## @@ -32,10 +32,13 @@ import org.apache.kafka.common.Uuid.ZERO_UUID import org.apache.kafka.common.errors.{InvalidRequestException, NotControllerException, TopicDeletionDisabledException} import org.apache.kafka.common.memory.MemoryPool import org.apache.kafka.common.message.ApiMessageType.ListenerType +import org.apache.kafka.common.message.CreateTopicsRequestData.{CreatableTopic, CreatableTopicCollection} +import org.apache.kafka.common.message.CreateTopicsResponseData.CreatableTopicResult import org.apache.kafka.common.message.DeleteTopicsRequestData.DeleteTopicState import org.apache.kafka.common.message.DeleteTopicsResponseData.DeletableTopicResult -import org.apache.kafka.common.message.{BrokerRegistrationRequestData, DeleteTopicsRequestData} +import org.apache.kafka.common.message.{BrokerRegistrationRequestData, CreateTopicsRequestData, DeleteTopicsRequestData} import org.apache.kafka.common.network.{ClientInformation, ListenerName} +import org.apache.kafka.common.protocol.Errors.{INVALID_REQUEST, NONE, TOPIC_AUTHORIZATION_FAILED} Review comment: Good point. I will add imports for all the Errors to make the code more readable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org