ijuma commented on a change in pull request #10445:
URL: https://github.com/apache/kafka/pull/10445#discussion_r608212051



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/producer/internals/FutureRecordMetadata.java
##########
@@ -107,7 +108,7 @@ Long checksumOrNull() {
     RecordMetadata value() {
         if (nextRecordMetadata != null)
             return nextRecordMetadata.value();
-        return new RecordMetadata(result.topicPartition(), 
this.result.baseOffset(), this.relativeOffset,
+        return new RecordMetadata(result.topicPartition(), 
this.result.baseOffset(), this.batchIndex,

Review comment:
       I can also add a comment as part of 
https://github.com/apache/kafka/pull/10470 if that's easier (that's how I ran 
into this). Looking at the code, it does seem like it's intended.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to