jthurne commented on a change in pull request #10490:
URL: https://github.com/apache/kafka/pull/10490#discussion_r608641584
##########
File path: build.gradle
##########
@@ -1148,8 +1155,10 @@ project(':clients') {
task createVersionFile(dependsOn: determineCommitId) {
ext.receiptFile = file("$buildDir/kafka/$buildVersionFileName")
+ inputs.property('commitId', commitId)
+ inputs.property('version', version)
outputs.file receiptFile
- outputs.upToDateWhen { false }
+ outputs.cacheIf { true }
Review comment:
Yeah, that's true. In this case, the cost to zip up this small file is
also tiny, but either way, there's really no benefit to caching on these tasks
since they run so fast anyway. I'll go ahead and remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
