dengziming commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r609608513
##########
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##########
@@ -2235,6 +2233,7 @@ private Long append(int epoch, List<T> records, boolean
isAtomic) {
} else {
offset = accumulator.append(epoch, records);
}
+
Review comment:
nit: redundant line feed
##########
File path: raft/src/test/java/org/apache/kafka/raft/QuorumStateTest.java
##########
@@ -269,7 +272,7 @@ public void testCandidateToLeader() throws IOException {
assertTrue(state.isCandidate());
assertEquals(1, state.epoch());
- state.transitionToLeader(0L);
+ state.transitionToLeader(0L, accumulator);
LeaderState leaderState = state.leaderStateOrThrow();
Review comment:
nit: add generic type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
