[GitHub] [kafka] abbccdda commented on a change in pull request #10482: KAFKA-12499: add transaction timeout verification

[GitBox]

abbccdda commented on a change in pull request #10482:
URL: https://github.com/apache/kafka/pull/10482#discussion_r609922102



##########
File path: 
streams/examples/src/main/java/org/apache/kafka/streams/examples/pageview/PageViewTypedDemo.java
##########
@@ -181,7 +181,7 @@ public static void main(final String[] args) {
         props.put(StreamsConfig.DEFAULT_VALUE_SERDE_CLASS_CONFIG, 
JSONSerde.class);
         props.put(StreamsConfig.DEFAULT_WINDOWED_VALUE_SERDE_INNER_CLASS, 
JSONSerde.class);
         props.put(StreamsConfig.CACHE_MAX_BYTES_BUFFERING_CONFIG, 0);
-        props.put(StreamsConfig.COMMIT_INTERVAL_MS_CONFIG, 1000);
+        props.put(StreamsConfig.COMMIT_INTERVAL_MS_CONFIG, 1000L);

Review comment:
       Just realized that it's safer to use the correct long type instead of 
having int/long/string mixed as much as possible. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org