jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r610100370
##########
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##########
@@ -601,6 +601,9 @@ private[log] object LogCleanerManager extends Logging {
// the active segment is always uncleanable
Option(log.activeSegment.baseOffset),
+ // we do not want to clean past the high watermark
+ Option(log.highWatermark),
Review comment:
This would cause issues during tests where if we didn't update the
highWatermark and tried to compact (and update the logStartOffset) we would
throw an exception since we can't update the logStartOffset higher than the HW.
This made me think we also shouldn't compact beyond the HW. I'm good with using
`lastStableOffset`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
