MarcoLotz commented on a change in pull request #10042:
URL: https://github.com/apache/kafka/pull/10042#discussion_r610877439
##########
File path:
streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java
##########
@@ -247,6 +278,32 @@ public void
shouldDetermineInternalTopicBasedOnTopicName1() {
assertTrue(streamsResetter.matchesInternalTopicFormat("appId-KTABLE-FK-JOIN-SUBSCRIPTION-REGISTRATION-12323232-topic"));
}
+ @Test
+ public void testResetToDatetimeWhenPartitionIsEmptyResetsToLatestOffset() {
+ final long[] beginningAndEndOffsets = {0L, 5L, 10L, 20L};
Review comment:
On this one, seems to me that only one value is sufficient. As the test
describes `testResetToDatetimeWhenPartitionIsEmptyResetsToLatestOffset`, the
partition is empty - thus beginning offset == end offset. I will change to have
a beginning offset equals to 5 anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
