hachikuji commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r610908966
##########
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##########
@@ -601,6 +601,9 @@ private[log] object LogCleanerManager extends Logging {
// the active segment is always uncleanable
Option(log.activeSegment.baseOffset),
+ // we do not want to clean past the high watermark
+ Option(log.highWatermark),
Review comment:
In practice, we do not allow the log start offset to get ahead of the
high watermark, so I am not sure that is a real issue. Still, I cannot think of
a strong reason to allow cleaning above the high watermark, so maybe it is
simpler to prevent it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
