C0urante opened a new pull request #10528:
URL: https://github.com/apache/kafka/pull/10528


   [Jira](https://issues.apache.org/jira/browse/KAFKA-12497)
   
   This change serves two purposes:
   1. Eliminate unnecessary log messages for offset commit of tasks that don't 
need to perform offset commits (e.g., a task that has failed and for which all 
data has been flushed and committed)
   2. Stop blocking the offset commit thread unnecessarily for flushes that 
will never succeed because the task's producer has failed to send a record in 
the current batch with a non-retriable error
   
   Existing unit tests for the `OffsetStorageWriter` are tweaked to verify the 
small change made to it. Several new unit tests are added for the 
`WorkerSourceTask` that cover various cases where offset commits should not be 
attempted, and some existing tests are modified to cover cases where offset 
commits either should or should not be attempted.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to