jsancio commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r611772289
##########
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##########
@@ -1876,12 +1836,12 @@ private void appendBatch(
}
private long maybeAppendBatches(
- LeaderState state,
+ LeaderState<T> state,
long currentTimeMs
) {
- long timeUnitFlush = accumulator.timeUntilDrain(currentTimeMs);
+ long timeUnitFlush = state.accumulator().timeUntilDrain(currentTimeMs);
Review comment:
@hachikuji we had this discussion in the PR that introduced the
`BatchAccumulator`. I was under the impression that we agreed to not use the
word "flush" since in Java that word is usually used to represent some kind of
IO sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
