[
https://issues.apache.org/jira/browse/KAFKA-12642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17319766#comment-17319766
]
Guozhang Wang commented on KAFKA-12642:
---------------------------------------
Hi [~nicolas.guyomar] Maybe in the existing log message, we can print the
`protocols` and `supportedProtocols` of the member, in the form of <string,
number-of-bytes>? If you agree, please feel free to submit a PR.
> Improve Rebalance reason upon metadata change
> ---------------------------------------------
>
> Key: KAFKA-12642
> URL: https://issues.apache.org/jira/browse/KAFKA-12642
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Reporter: Nicolas Guyomar
> Priority: Minor
>
> Whenever the known member metadata does not match anymore the one from a
> JoinGroupRequest, the GroupCoordinator triggers a rebalance with the
> following reason "Updating metadata for member ${member.memberId}" but
> there 2 underlying reasons from that part of the code in MemberMetadata.scala
> :
> {code:java}
> def matches(protocols: List[(String, Array[Byte])]): Boolean = {
> if (protocols.size != this.supportedProtocols.size)
> return false
> for (i <- protocols.indices) {
> val p1 = protocols(i)
> val p2 = supportedProtocols(i)
> if (p1._1 != p2._1 || !util.Arrays.equals(p1._2, p2._2))
> return false
> }
> true
> }{code}
> Could we improve the Rebalance Reason with a bit more detail maybe ?
>
> Thank you
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
