predatorray commented on pull request #10525: URL: https://github.com/apache/kafka/pull/10525#issuecomment-818424067
Hi, @showuon. Thanks for your review! As per your question, I just follow the suggestion from @viktorsomogyi in the previous pr #5858 . I think maybe a subclass of KafkaException will be better since it indicates something more like an implementation error. To be honest, I cannot find any existing classes that suit this error, so i create a new one. If you think it will be better to throw `IllegalArgumentException` is better, i will change the code so we will not have introduce another new KafkaException to the code base. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
