dongjinleekr commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r612429317
########## File path: eclipse-formatter.xml ########## @@ -0,0 +1,52 @@ +<?xml version="1.0" encoding="UTF-8" standalone="no"?> +<profiles version="1"> +<profile kind="CodeFormatterProfile" name="ApacheKafka" version="1"> + <!-- Import ordering --> + <setting id="org.eclipse.jdt.core.formatter.blank_lines_between_import_groups" value="1"/> + <setting id="org.eclipse.jdt.core.formatter.blank_lines_before_imports" value="1"/> + <setting id="org.eclipse.jdt.core.formatter.blank_lines_after_imports" value="1"/> + + <!-- Line --> + <setting id="org.eclipse.jdt.core.formatter.lineSplit" value="120"/> + <setting id="org.eclipse.jdt.core.formatter.comment.line_length" value="120"/> Review comment: Agree. It seems like removing this rule would be better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org