cmccabe commented on a change in pull request #10505:
URL: https://github.com/apache/kafka/pull/10505#discussion_r612738586
##########
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##########
@@ -35,8 +36,8 @@ import org.apache.kafka.common.internals.FatalExitError
import
org.apache.kafka.common.message.CreateTopicsResponseData.CreatableTopicResult
import
org.apache.kafka.common.message.DeleteTopicsResponseData.{DeletableTopicResult,
DeletableTopicResultCollection}
import
org.apache.kafka.common.message.MetadataResponseData.MetadataResponseBroker
-import org.apache.kafka.common.message.{BeginQuorumEpochResponseData,
BrokerHeartbeatResponseData, BrokerRegistrationResponseData,
CreateTopicsRequestData, CreateTopicsResponseData, DeleteTopicsRequestData,
DeleteTopicsResponseData, DescribeQuorumResponseData,
EndQuorumEpochResponseData, FetchResponseData, MetadataResponseData,
SaslAuthenticateResponseData, SaslHandshakeResponseData,
UnregisterBrokerResponseData, VoteResponseData}
-import org.apache.kafka.common.protocol.Errors.{INVALID_REQUEST,
TOPIC_AUTHORIZATION_FAILED}
+import org.apache.kafka.common.message._
+import org.apache.kafka.common.protocol.Errors._
Review comment:
I think this makes it more readable. Long lines make reading and
merging difficult
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
