kowshik commented on a change in pull request #10478:
URL: https://github.com/apache/kafka/pull/10478#discussion_r613795734
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -255,19 +261,21 @@ case object SnapshotGenerated extends
LogStartOffsetIncrementReason {
@threadsafe
class Log(@volatile private var _dir: File,
@volatile var config: LogConfig,
+ val segments: LogSegments,
Review comment:
I took a stab at this. Things changed a bit after I did the refactoring
that Jun suggested
[here](https://github.com/apache/kafka/pull/10478#discussion_r610933966). In
the latest version of the PR, `LogComponents` has been renamed to a class
called `LoadedLogOffsets` which now only contains (logStartOffset,
recoveryPoint, nextOffsetMetadata). It seemed reasonable to just pass these in
as 3 separate parameters into `Log`, since the `LeaderEpochFileCache` and
`ProducerStateManager` are no longer inside the `LoadedLogOffsets` object those
have to anyway be passed in separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
