spena commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r614312224
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java
##########
@@ -211,6 +263,66 @@ private void assertUniqueStoreNames(final
WindowBytesStoreSupplier supplier,
return builder;
}
+ @SuppressWarnings("unchecked")
+ private static <K, V1, V2> StoreBuilder<WindowStore<KeyAndJoinSide<K>,
LeftOrRightValue<V1, V2>>> outerJoinWindowStoreBuilder(final String storeName,
+
final JoinWindows windows,
+
final
StreamJoinedInternal<K, V1, V2> streamJoinedInternal) {
+ final StoreBuilder<WindowStore<KeyAndJoinSide<K>, LeftOrRightValue<V1,
V2>>> builder = new TimeOrderedWindowStoreBuilder<KeyAndJoinSide<K>,
LeftOrRightValue<V1, V2>>(
+ persistentTimeOrderedWindowStore(
+ storeName + "-store",
+ Duration.ofMillis(windows.size() + windows.gracePeriodMs()),
+ Duration.ofMillis(windows.size())
+ ),
+ new KeyAndJoinSideSerde<>(streamJoinedInternal.keySerde()),
+ new LeftOrRightValueSerde(streamJoinedInternal.valueSerde(),
streamJoinedInternal.otherValueSerde()),
+ Time.SYSTEM
Review comment:
It will require more changes just to allow that. The `KStreamImplJoin`
constructor, where we could overload to pass a `Time` mock object, is only used
by the `KStreamImplJoinImpl` class. The tests use the `StreamsBuilder` to
create the joins, and they do not accept a Time object.
Also, the `Stores` class, which is called by `KStreamImplJoin`, does not
mock it. Maybe because the same code changes required just for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
