[GitHub] [kafka] wcarlson5 commented on a change in pull request #10544: KAFKA-12648: minimum changes for error handling namedTopologies

[GitBox]

wcarlson5 commented on a change in pull request #10544:
URL: https://github.com/apache/kafka/pull/10544#discussion_r614398250



##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -471,6 +472,10 @@ private void replaceStreamThread(final Throwable 
throwable) {
 
     private void handleStreamsUncaughtException(final Throwable throwable,
                                                 final 
StreamsUncaughtExceptionHandler streamsUncaughtExceptionHandler) {
+        if (throwable instanceof NamedTopologyStreamsException) {
+            String name = ((NamedTopologyStreamsException) 
throwable).getTopologyName();
+            ((StreamThread) 
Thread.currentThread()).deprioritizeNamedTopology(name);

Review comment:
       The thread is guaranteed to be handled on the dying thread. Though we 
might want to call this on the new thread
   
   EDIT: we def will need to track the failed topologies in `KafkaStreams`, 
though tracking successes across restarts will be an issue




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org