[GitHub] [kafka] wcarlson5 commented on a change in pull request #10565: KAFKA-12691: Add case where task can be considered idling

[GitBox]

wcarlson5 commented on a change in pull request #10565:
URL: https://github.com/apache/kafka/pull/10565#discussion_r616777330



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -692,6 +699,7 @@ public boolean process(final long wallClockTime) {
                 return false;
             }
         }
+        timeCurrentIdlingStarted = Optional.empty();

Review comment:
       My thought was if the record becomes not null after It was not 
processable in the previous iteration we would not call isProcessable. Is this 
case guaranteed not to happen? If so we don't need this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org