ableegoldman opened a new pull request #10571: URL: https://github.com/apache/kafka/pull/10571
We haven't yet found the time to implement spill-to-disk for the suppression buffer, so we should remove the `SPILL_TO_DISK` enum to avoid confusion. Technically this enum is in an internal package, and a user would have to be invoking the `StrictBufferConfigImpl` constructor (which is also internal) to have reason to access this enum at all. But users don't always know/notice/care that APIs are internal, or they may just be browsing the source code, so we may as well remove this source of confusion. It's always kind of confusing to see this as a dev. At the moment if a user does choose this strategy, an UnsupportedOperationException claiming that this is a bug will be thrown when the buffer is full, so it's not like anything too bad would happen...it's just awkward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
