[ 
https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326635#comment-17326635
 ] 

Mikhail Panchenko commented on KAFKA-12696:
-------------------------------------------

Ok. Just to confirm, the confluence where KIPs are created is a separate login, 
so I should sign up?

Re: the naming convention, is this documented somewhere that I can reference in 
the KIP? I'm inclined to make the KIP a bit broader than "change this one 
interface." It would be nice to be able to reference the convention directly 
when proposing to change it. I see a "avoid getters and setters" in the [Coding 
Guide|http://kafka.apache.org/coding-guide.html], but that appears to be 
directed at Scala, not Java code.

> Add standard getters to LagInfo class to allow automatic serialization
> ----------------------------------------------------------------------
>
>                 Key: KAFKA-12696
>                 URL: https://issues.apache.org/jira/browse/KAFKA-12696
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Mikhail Panchenko
>            Assignee: Mikhail Panchenko
>            Priority: Trivial
>              Labels: needs-kip
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> The LagInfo class has non-standard getters for its member variables. This 
> means that Jackson and other serialization frameworks do not know how to 
> serialize them without additional annotations. So when implementing the sort 
> of system that KAFKA-6144 is meant to enable, as documented here in docs like 
> [Kafka Streams Interactive 
> Queries|https://docs.confluent.io/platform/current/streams/developer-guide/interactive-queries.html#querying-state-stores-during-a-rebalance],
>  one has to either inject a bunch of custom serialization logic into Jersey 
> or wrap this class.
> The patch to fix this is trivial, and I will be putting one up shortly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to