cmccabe commented on a change in pull request #10564:
URL: https://github.com/apache/kafka/pull/10564#discussion_r618138592
##########
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##########
@@ -957,22 +890,27 @@ ApiError electLeader(String topic, int partitionId,
boolean unclean,
return ControllerResult.of(records, reply);
}
- int bestLeader(int[] replicas, int[] isr, boolean unclean) {
+ static boolean isGoodLeader(int[] isr, int leader) {
+ return Replicas.contains(isr, leader);
+ }
+
+ static int bestLeader(int[] replicas, int[] isr, boolean uncleanOk,
+ Function<Integer, Boolean> isAcceptableLeader) {
+ int bestUnclean = NO_LEADER;
for (int i = 0; i < replicas.length; i++) {
int replica = replicas[i];
- if (Replicas.contains(isr, replica)) {
- return replica;
- }
- }
- if (unclean) {
- for (int i = 0; i < replicas.length; i++) {
- int replica = replicas[i];
- if (clusterControl.unfenced(replica)) {
+ if (isAcceptableLeader.apply(replica)) {
+ if (bestUnclean == NO_LEADER) bestUnclean = replica;
+ if (Replicas.contains(isr, replica)) {
return replica;
}
}
}
- return NO_LEADER;
+ return uncleanOk ? bestUnclean : NO_LEADER;
+ }
+
+ static boolean electionWasClean(int newLeader, int[] prevIsr) {
Review comment:
I will just call it isr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
