satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r620437193
##########
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/AbstractMetadataMessageSerde.java
##########
@@ -19,52 +19,41 @@
import org.apache.kafka.common.protocol.ApiMessage;
import org.apache.kafka.common.protocol.ByteBufferAccessor;
import org.apache.kafka.common.protocol.ObjectSerializationCache;
-import org.apache.kafka.common.utils.ByteUtils;
+import org.apache.kafka.common.protocol.Readable;
import org.apache.kafka.metadata.ApiMessageAndVersion;
-
+import org.apache.kafka.raft.metadata.AbstractMetadataRecordSerde;
import java.nio.ByteBuffer;
/**
- * This class provides serialization/deserialization of {@code
ApiMessageAndVersion}.
+ * This class provides serialization/deserialization of {@code
ApiMessageAndVersion}. This can be used as
+ * serialization/deserialization protocol for any metadata records derived of
{@code ApiMessage}s.
* <p></p>
* Implementors need to extend this class and implement {@link
#apiMessageFor(short)} method to return a respective
* {@code ApiMessage} for the given {@code apiKey}. This is required to
deserialize the bytes to build the respective
* {@code ApiMessage} instance.
*/
-public abstract class AbstractApiMessageAndVersionSerde {
+public abstract class AbstractMetadataMessageSerde {
Review comment:
`ReadableWritableApiMessageSerde` instead of `WritableApiMessageSerde`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
