[GitHub] [kafka] jolshan commented on a change in pull request #10590: KAFKA-5761: support ByteBuffer as value in ProducerRecord and avoid redundant serialization when it's used

[GitBox]

jolshan commented on a change in pull request #10590:
URL: https://github.com/apache/kafka/pull/10590#discussion_r620608169



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/producer/Partitioner.java
##########
@@ -34,10 +34,9 @@
      * @param key The key to partition on (or null if no key)
      * @param keyBytes The serialized key to partition on( or null if no key)
      * @param value The value to partition on or null
-     * @param valueBytes The serialized value to partition on or null
      * @param cluster The current cluster metadata
      */
-    public int partition(String topic, Object key, byte[] keyBytes, Object 
value, byte[] valueBytes, Cluster cluster);

Review comment:
       This is a public interface, so we can't change the parameters without a 
KIP. We need to consider compatibility with others who may be using the old 
interface. This is likely why this parameter still exists.  See 
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org