[GitHub] [kafka] ableegoldman commented on a change in pull request #10597: KAFKA-5876: Apply StreamsNotStartedException for Interactive Queries

[GitBox]

ableegoldman commented on a change in pull request #10597:
URL: https://github.com/apache/kafka/pull/10597#discussion_r620653928



##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -1524,6 +1527,12 @@ public void cleanUp() {
      *                                    an InvalidStateStoreException is 
thrown upon store access.
      */
     public <T> T store(final StoreQueryParameters<T> storeQueryParameters) {
+        synchronized (stateLock) {
+            if (state == State.CREATED) {
+                throw new StreamsNotStartedException("KafkaStreams is not 
started, you can retry and wait until to running.");

Review comment:
       Technically we don't need to wait for it to be running, they just need 
to start it:
   ```suggestion
                   throw new StreamsNotStartedException("KafkaStreams has not 
been started, you can retry after calling start()");
   ```

##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -1516,6 +1517,8 @@ public void cleanUp() {
      *
      * @param storeQueryParameters   the parameters used to fetch a queryable 
store
      * @return A facade wrapping the local {@link StateStore} instances
+     * @throws StreamsNotStartedException if Kafka Streams state is {@link 
KafkaStreams.State#CREATED CREATED}. Just
+     *         retry and wait until to {@link KafkaStreams.State#RUNNING 
RUNNING}

Review comment:
       ```suggestion
        * @throws StreamsNotStartedException If user has not started the 
KafkaStreams and it's still in {@link KafkaStreams.State#CREATED CREATED}.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org