hachikuji commented on a change in pull request #10599: URL: https://github.com/apache/kafka/pull/10599#discussion_r621484136
########## File path: clients/src/test/java/org/apache/kafka/clients/admin/internals/AbortTransactionHandlerTest.java ########## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.clients.admin.internals; + +import org.apache.kafka.clients.admin.AbortTransactionSpec; +import org.apache.kafka.common.KafkaException; +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.common.errors.ClusterAuthorizationException; +import org.apache.kafka.common.errors.InvalidProducerEpochException; +import org.apache.kafka.common.errors.TransactionCoordinatorFencedException; +import org.apache.kafka.common.message.WriteTxnMarkersRequestData; +import org.apache.kafka.common.message.WriteTxnMarkersResponseData; +import org.apache.kafka.common.protocol.Errors; +import org.apache.kafka.common.requests.WriteTxnMarkersRequest; +import org.apache.kafka.common.requests.WriteTxnMarkersResponse; +import org.apache.kafka.common.utils.LogContext; +import org.junit.jupiter.api.Test; + +import static java.util.Collections.emptyList; +import static java.util.Collections.emptySet; +import static java.util.Collections.singleton; +import static java.util.Collections.singletonList; +import static org.apache.kafka.common.utils.Utils.mkSet; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class AbortTransactionHandlerTest { + private final LogContext logContext = new LogContext(); + private final TopicPartition topicPartition = new TopicPartition("foo", 5); + private final AbortTransactionSpec abortSpec = new AbortTransactionSpec( + topicPartition, 12345L, (short) 15, 4321); + + @Test + public void testInvalidBuildRequestCall() { + AbortTransactionHandler handler = new AbortTransactionHandler(abortSpec, logContext); + assertThrows(IllegalArgumentException.class, () -> handler.buildRequest(1, + emptySet())); + assertThrows(IllegalArgumentException.class, () -> handler.buildRequest(1, + mkSet(new TopicPartition("foo", 1)))); + assertThrows(IllegalArgumentException.class, () -> handler.buildRequest(1, + mkSet(topicPartition, new TopicPartition("foo", 1)))); + } + + @Test + public void testValidBuildRequestCall() { + AbortTransactionHandler handler = new AbortTransactionHandler(abortSpec, logContext); + WriteTxnMarkersRequest.Builder request = handler.buildRequest(1, singleton(topicPartition)); + assertEquals(1, request.data.markers().size()); + + WriteTxnMarkersRequestData.WritableTxnMarker markerRequest = request.data.markers().get(0); + assertEquals(abortSpec.producerId(), markerRequest.producerId()); + assertEquals(abortSpec.producerEpoch(), markerRequest.producerEpoch()); + assertEquals(abortSpec.coordinatorEpoch(), markerRequest.coordinatorEpoch()); + assertEquals(1, markerRequest.topics().size()); + + WriteTxnMarkersRequestData.WritableTxnMarkerTopic topicRequest = markerRequest.topics().get(0); + assertEquals(abortSpec.topicPartition().topic(), topicRequest.name()); + assertEquals(singletonList(abortSpec.topicPartition().partition()), topicRequest.partitionIndexes()); + } + + @Test + public void testInvalidHandleResponseCall() { + AbortTransactionHandler handler = new AbortTransactionHandler(abortSpec, logContext); + WriteTxnMarkersResponseData response = new WriteTxnMarkersResponseData(); + assertThrows(IllegalArgumentException.class, () -> handler.handleResponse(1, + emptySet(), new WriteTxnMarkersResponse(response))); + assertThrows(IllegalArgumentException.class, () -> handler.handleResponse(1, + mkSet(new TopicPartition("foo", 1)), new WriteTxnMarkersResponse(response))); + assertThrows(IllegalArgumentException.class, () -> handler.handleResponse(1, + mkSet(topicPartition, new TopicPartition("foo", 1)), new WriteTxnMarkersResponse(response))); + } + + @Test + public void testInvalidResponse() { + AbortTransactionHandler handler = new AbortTransactionHandler(abortSpec, logContext); + + WriteTxnMarkersResponseData response = new WriteTxnMarkersResponseData(); + assertFailed(KafkaException.class, topicPartition, handler.handleResponse(1, singleton(topicPartition), + new WriteTxnMarkersResponse(response))); + + WriteTxnMarkersResponseData.WritableTxnMarkerResult markerResponse = + new WriteTxnMarkersResponseData.WritableTxnMarkerResult(); + response.markers().add(markerResponse); + assertFailed(KafkaException.class, topicPartition, handler.handleResponse(1, singleton(topicPartition), + new WriteTxnMarkersResponse(response))); + + markerResponse.setProducerId(abortSpec.producerId()); + assertFailed(KafkaException.class, topicPartition, handler.handleResponse(1, singleton(topicPartition), + new WriteTxnMarkersResponse(response))); + + WriteTxnMarkersResponseData.WritableTxnMarkerTopicResult topicResponse = + new WriteTxnMarkersResponseData.WritableTxnMarkerTopicResult(); + markerResponse.topics().add(topicResponse); + assertFailed(KafkaException.class, topicPartition, handler.handleResponse(1, singleton(topicPartition), + new WriteTxnMarkersResponse(response))); + + topicResponse.setName(abortSpec.topicPartition().topic()); + assertFailed(KafkaException.class, topicPartition, handler.handleResponse(1, singleton(topicPartition), + new WriteTxnMarkersResponse(response))); + + WriteTxnMarkersResponseData.WritableTxnMarkerPartitionResult partitionResponse = + new WriteTxnMarkersResponseData.WritableTxnMarkerPartitionResult(); + topicResponse.partitions().add(partitionResponse); + assertFailed(KafkaException.class, topicPartition, handler.handleResponse(1, singleton(topicPartition), + new WriteTxnMarkersResponse(response))); + + partitionResponse.setPartitionIndex(abortSpec.topicPartition().partition()); + topicResponse.setName(abortSpec.topicPartition().topic() + "random"); + assertFailed(KafkaException.class, topicPartition, handler.handleResponse(1, singleton(topicPartition), + new WriteTxnMarkersResponse(response))); + + topicResponse.setName(abortSpec.topicPartition().topic()); + markerResponse.setProducerId(abortSpec.producerId() + 1); + assertFailed(KafkaException.class, topicPartition, handler.handleResponse(1, singleton(topicPartition), + new WriteTxnMarkersResponse(response))); + } + + @Test + public void testSuccessfulResponse() { + assertCompleted(abortSpec.topicPartition(), handleWithError(abortSpec, Errors.NONE)); + } + + @Test + public void testRetriableErrors() { + assertUnmapped(abortSpec.topicPartition(), handleWithError(abortSpec, Errors.NOT_LEADER_OR_FOLLOWER)); + assertUnmapped(abortSpec.topicPartition(), handleWithError(abortSpec, Errors.UNKNOWN_TOPIC_OR_PARTITION)); + assertUnmapped(abortSpec.topicPartition(), handleWithError(abortSpec, Errors.REPLICA_NOT_AVAILABLE)); + assertUnmapped(abortSpec.topicPartition(), handleWithError(abortSpec, Errors.BROKER_NOT_AVAILABLE)); + } + + @Test + public void testFatalErrors() { Review comment: Yes, thanks for reminding me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
