ableegoldman commented on a change in pull request #8923:
URL: https://github.com/apache/kafka/pull/8923#discussion_r621665639
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/ResetIntegrationTest.java
##########
@@ -151,6 +151,22 @@ public void
shouldNotAllowToResetWhenIntermediateTopicAbsent() {
Assert.assertEquals(1, exitCode);
}
+ @Test
+ public void shouldNotAllowToResetWhenSpecifiedInternalTopicAbsent() {
Review comment:
Hah, maybe I should have asked why are all of those tests not also in
`AbstractResetIntegrationTest`. Seems like almost everything that applies here
would also be good to test in the SSL version of the test (which AFAICT is the
only other one to extend the AbstractResetIntegrationTest).
But I'm ok with leaving it as is, and maybe we can just look into this as
followup work unless there is a good reason for them to be where they are
(which I can't think of but my imagination is not endless)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
