jsancio commented on a change in pull request #10497:
URL: https://github.com/apache/kafka/pull/10497#discussion_r621670833
##########
File path:
core/src/test/scala/unit/kafka/server/metadata/BrokerMetadataListenerTest.scala
##########
@@ -108,18 +109,29 @@ class BrokerMetadataListenerTest {
assertEquals(localPartitions, localRemoved.map(_.toTopicPartition).toSet)
}
+ private def applyBatch(
+ records: List[ApiMessageAndVersion]
+ ): Unit = {
+ val baseOffset = lastMetadataOffset + 1
Review comment:
Hmm. This is minor but does this mean that a `baseOffset` of 0 is not
possible since `lastMetadataOffset` is initialized to `0`? Is this also true
for a "regular" Kafka topic partition? Or is this just an side effect of how
this test gets constructed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
