AndroideRob commented on a change in pull request #10591:
URL: https://github.com/apache/kafka/pull/10591#discussion_r622314643
##########
File path: docs/security.html
##########
@@ -319,7 +319,7 @@ <h5>SSL key and certificates in PEM format</h5>
We need to configure the following property in server.properties,
which must have one or more comma-separated values:
<pre>listeners</code></pre>
- If SSL is not enabled for inter-broker communication (see below
for how to enable it), both PLAINTEXT and SSL ports will be necessary.
+ If SSL is enabled for inter-broker communication (see below for
how to enable it), both PLAINTEXT and SSL ports will be necessary.
Review comment:
You are right, my bad, will fix
##########
File path: docs/upgrade.html
##########
@@ -420,11 +420,11 @@ <h4><a id="upgrade_2_4_0" href="#upgrade_2_4_0">Upgrading
from 0.8.x, 0.9.x, 0.1
if there are no snapshot files in 3.4 data directory. For more details
about the workaround please refer to <a
href="https://cwiki.apache.org/confluence/display/ZOOKEEPER/Upgrade+FAQ";>ZooKeeper
Upgrade FAQ</a>.
</li>
<li>
- An embedded Jetty based <a
href="http://zookeeper.apache.org/doc/r3.5.6/zookeeperAdmin.html#sc_adminserver";>AdminServer</a>
added in ZooKeeper 3.5.
+ An embedded Jetty based <a
href="http://zookeeper.apache.org/doc/r3.5.7/zookeeperAdmin.html#sc_adminserver";>AdminServer</a>
added in ZooKeeper 3.5.
Review comment:
Alright, will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
