satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r622766875
##########
File path:
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java
##########
@@ -270,9 +247,9 @@ public String toString() {
"remoteLogSegmentId=" + remoteLogSegmentId +
", startOffset=" + startOffset +
", endOffset=" + endOffset +
- ", brokerId=" + brokerId +
+ ", brokerId=" + brokerId() +
Review comment:
afaik, javac(JDK8+) already converts that into `StringBuilder` and it is
not required to replace + to `StringBuilder` concatenation code here.
Actually, we should avoid doing that as javac has better optimizations like
[JEP-280](https://openjdk.java.net/jeps/280).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
