[
https://issues.apache.org/jira/browse/KAFKA-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337615#comment-17337615
]
Matthias J. Sax edited comment on KAFKA-12718 at 4/30/21, 8:47 PM:
-------------------------------------------------------------------
I just realized that the issue is actually not within `suppress()` but within
`KStreamSessionWindowAggregateProcessor` – note that the test is question test
the processor, not suppress().
It seem we would prefer to not to enforce `grace > gap` and thus, we should fix
how we compute `closeTime` inside the processor and add the currently missing
`gap` parameter.
[~byusti] feel free to start working on a PR. Let us know if you have any
further questions. I added you to the list of contributors and assigned the
ticket. You can know also self-assign tickets.
was (Author: mjsax):
I just realized that the issue is actually not within `suppress()` but within
`KStreamSessionWindowAggregateProcessor` – note that the test is question test
the processor, not suppress().
It seem we would prefer to not to enforce `grace > gap` and thus, we should fix
how we compute `closeTime` inside the processor and add the currently missing
`gap` parameter.
[~byusti] feel free to start working on a PR. Let us know if you have any
further questions.
> SessionWindows are closed too early
> -----------------------------------
>
> Key: KAFKA-12718
> URL: https://issues.apache.org/jira/browse/KAFKA-12718
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Reporter: Matthias J. Sax
> Assignee: Bernardo Yusti
> Priority: Major
> Labels: beginner, easy-fix, newbie
> Fix For: 3.0.0
>
>
> SessionWindows are defined based on a {{gap}} parameter, and also support an
> additional {{grace-period}} configuration to handle out-of-order data.
> To incorporate the session-gap a session window should only be closed at
> {{window-end + gap}} and to incorporate grace-period, the close time should
> be pushed out further to {{window-end + gap + grace}}.
> However, atm we compute the window close time as {{window-end + grace}}
> omitting the {{gap}} parameter.
> Because default grace-period is 24h most users might not notice this issues.
> Even if they set a grace period explicitly (eg, when using suppress()), they
> would most likely set a grace-period larger than gap-time not hitting the
> issue (or maybe only realize it when inspecting the behavior closely).
> However, if a user wants to disable the grace-period and sets it to zero (on
> any other value smaller than gap-time), sessions might be close too early and
> user might notice.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
