wenbingshen commented on pull request #10617: URL: https://github.com/apache/kafka/pull/10617#issuecomment-831399088
> @wenbingshen : It would be useful to be clear what the PR wants to address. To me, if the index is corrupted because of our recovery logic (e.g., not handling cleaning shutdown file properly), we should just fix the cause. It's possible that after a clean restart, the index is corrupted due to storage issues. In that case, validating the index when the index is opened could potentially be useful. If we want to do that, it seems that we should we just do the validation on every index open, instead of just for the active segment? @junrao Thank you for your reply. You've got a point there. This PR problem is really due to not handling cleaning shutdown file properly. It's right to fix the root cause. After a successful restart, the index file is damaged due to storage reasons. If we need to solve this problem, we need other PR to do it. For opening the index file, we may need to check the integrity just like checking the entries in the checkpoint file. I will close this PR because the problem has been fixed. For the latter situation mentioned by you, I will think about it. If I have any good ideas, I will give you feedback again. Thank you. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
