scott-hendricks commented on a change in pull request #10621:
URL: https://github.com/apache/kafka/pull/10621#discussion_r626049787
##########
File path:
trogdor/src/main/java/org/apache/kafka/trogdor/workload/ConstantThroughputGenerator.java
##########
@@ -26,17 +26,11 @@
* The lower the window size, the smoother the traffic will be. Using a 100ms
window offers no noticeable spikes in
* traffic while still being long enough to avoid too much overhead.
*
- * WARNING: Due to binary nature of throughput in terms of messages sent in a
window, each window will send at least 1
- * message, and each window sends the same number of messages, rounded down.
For example, 99 messages per second with a
- * 100ms window will only send 90 messages per second, or 9 messages per
window. Another example, in order to send only
- * 5 messages per second, a window size of 200ms is required. In cases like
these, both the `messagesPerSecond` and
- * `windowSizeMs` parameters should be adjusted together to achieve more
accurate throughput.
- *
* Here is an example spec:
*
* {
* "type": "constant",
- * "messagesPerSecond": 500,
+ * "messagesPerWindow": 50,
Review comment:
Sure, that's reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
