ableegoldman commented on a change in pull request #10568:
URL: https://github.com/apache/kafka/pull/10568#discussion_r626175996
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##########
@@ -396,6 +396,21 @@ public void close() {
log.info("Skipping to close non-initialized store {}",
entry.getKey());
}
}
+ for (final StateStore store : globalStateStores) {
Review comment:
Heh, @guozhangwang and I reviewed at the same time. I didn't notice that
`globalStores` would not be populated until restoration, whereas
`globalStateStores` is populated in the constructor. Imo we should just
populate `globalStores` in the constructor as well, but I guess that won't be
necessary if @guozhangwang does a quick followup to consolidate them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
