satishd commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r628139399
##########
File path: build.gradle
##########
@@ -1345,6 +1349,62 @@ project(':raft') {
}
}
+project(':server-common') {
+ archivesBaseName = "kafka-server-common"
+
+ dependencies {
+ implementation project(':clients')
Review comment:
I did not add `clients` as `api` dependency. We may need to do that as
the users of `server-common` need `org.apache.kafka.common.protocol` classes as
they are part of the APIs in `server-common` classes.
After this change, we can remove `clients` dependency from wherever
`server-common` module is directly used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
