ableegoldman commented on a change in pull request #10568:
URL: https://github.com/apache/kafka/pull/10568#discussion_r628815666
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##########
@@ -1381,6 +1364,313 @@ public WriteBufferManager writeBufferManager() {
return dbOptions.writeBufferManager();
}
+ @Override
+ public Options setMaxWriteBatchGroupSizeBytes(final long
maxWriteBatchGroupSizeBytes) {
+ dbOptions.setMaxWriteBatchGroupSizeBytes(maxWriteBatchGroupSizeBytes);
+ return this;
+ }
+
+ @Override
+ public long maxWriteBatchGroupSizeBytes() {
+ return dbOptions.maxWriteBatchGroupSizeBytes();
+ }
+
+ @Override
+ public Options oldDefaults(final int majorVersion, final int minorVersion)
{
+ columnFamilyOptions.oldDefaults(majorVersion, minorVersion);
+ return this;
+ }
+
+ @Override
+ public Options optimizeForSmallDb(final Cache cache) {
+ return super.optimizeForSmallDb(cache);
+ }
+
+ @Override
+ public AbstractCompactionFilter<? extends AbstractSlice<?>>
compactionFilter() {
+ return columnFamilyOptions.compactionFilter();
+ }
+
+ @Override
+ public AbstractCompactionFilterFactory<? extends
AbstractCompactionFilter<?>> compactionFilterFactory() {
+ return columnFamilyOptions.compactionFilterFactory();
+ }
+
+ @Override
+ public Options setStatsPersistPeriodSec(final int statsPersistPeriodSec) {
+ dbOptions.setStatsPersistPeriodSec(statsPersistPeriodSec);
+ return this;
+ }
+
+ @Override
+ public int statsPersistPeriodSec() {
+ return dbOptions.statsPersistPeriodSec();
+ }
+
+ @Override
+ public Options setStatsHistoryBufferSize(final long
statsHistoryBufferSize) {
+ dbOptions.setStatsHistoryBufferSize(statsHistoryBufferSize);
+ return this;
+ }
+
+ @Override
+ public long statsHistoryBufferSize() {
+ return dbOptions.statsHistoryBufferSize();
+ }
+
+ @Override
+ public Options setStrictBytesPerSync(final boolean strictBytesPerSync) {
+ dbOptions.setStrictBytesPerSync(strictBytesPerSync);
+ return this;
+ }
+
+ @Override
+ public boolean strictBytesPerSync() {
+ return dbOptions.strictBytesPerSync();
+ }
+
+ @Override
+ public Options setListeners(final List<AbstractEventListener> listeners) {
+ dbOptions.setListeners(listeners);
+ return this;
+ }
+
+ @Override
+ public List<AbstractEventListener> listeners() {
+ return dbOptions.listeners();
+ }
+
+ @Override
+ public Options setEnablePipelinedWrite(final boolean enablePipelinedWrite)
{
+ dbOptions.setEnablePipelinedWrite(enablePipelinedWrite);
+ return this;
+ }
+
+ @Override
+ public boolean enablePipelinedWrite() {
+ return dbOptions.enablePipelinedWrite();
+ }
+
+ @Override
+ public Options setUnorderedWrite(final boolean unorderedWrite) {
+ dbOptions.setUnorderedWrite(unorderedWrite);
+ return this;
+ }
+
+ @Override
+ public boolean unorderedWrite() {
+ return dbOptions.unorderedWrite();
+ }
+
+ @Override
+ public Options setSkipCheckingSstFileSizesOnDbOpen(final boolean
skipCheckingSstFileSizesOnDbOpen) {
+
dbOptions.setSkipCheckingSstFileSizesOnDbOpen(skipCheckingSstFileSizesOnDbOpen);
+ return this;
+ }
+
+ @Override
+ public boolean skipCheckingSstFileSizesOnDbOpen() {
+ return dbOptions.skipCheckingSstFileSizesOnDbOpen();
+ }
+
+ @Override
+ public Options setWalFilter(final AbstractWalFilter walFilter) {
+ dbOptions.setWalFilter(walFilter);
+ return this;
+ }
+
+ @Override
+ public WalFilter walFilter() {
+ return dbOptions.walFilter();
+ }
+
+ @Override
+ public Options setAllowIngestBehind(final boolean allowIngestBehind) {
+ dbOptions.setAllowIngestBehind(allowIngestBehind);
+ return this;
+ }
+
+ @Override
+ public boolean allowIngestBehind() {
+ return dbOptions.allowIngestBehind();
+ }
+
+ @Override
+ public Options setPreserveDeletes(final boolean preserveDeletes) {
+ dbOptions.setPreserveDeletes(preserveDeletes);
+ return this;
+ }
+
+ @Override
+ public boolean preserveDeletes() {
+ return dbOptions.preserveDeletes();
+ }
+
+ @Override
+ public Options setTwoWriteQueues(final boolean twoWriteQueues) {
+ dbOptions.setTwoWriteQueues(twoWriteQueues);
+ return this;
+ }
+
+ @Override
+ public boolean twoWriteQueues() {
+ return dbOptions.twoWriteQueues();
+ }
+
+ @Override
+ public Options setManualWalFlush(final boolean manualWalFlush) {
+ dbOptions.setManualWalFlush(manualWalFlush);
+ return this;
+ }
+
+ @Override
+ public boolean manualWalFlush() {
+ return dbOptions.manualWalFlush();
+ }
+
+ @Override
+ public Options setCfPaths(final Collection<DbPath> cfPaths) {
+ columnFamilyOptions.setCfPaths(cfPaths);
+ return this;
+ }
+
+ @Override
+ public List<DbPath> cfPaths() {
+ return columnFamilyOptions.cfPaths();
+ }
+
+ @Override
+ public Options setBottommostCompressionOptions(final CompressionOptions
bottommostCompressionOptions) {
+
columnFamilyOptions.setBottommostCompressionOptions(bottommostCompressionOptions);
+ return this;
+ }
+
+ @Override
+ public CompressionOptions bottommostCompressionOptions() {
+ return columnFamilyOptions.bottommostCompressionOptions();
+ }
+
+ @Override
+ public Options setTtl(final long ttl) {
+ columnFamilyOptions.setTtl(ttl);
Review comment:
Oh, I guess I didn't read it very carefully 😅 In that case we may want
to warn users that this option will not, in fact, provide "real" ttl (unless
also using FIFO compaction). I'd imagine users may see this new option pop up
and assume, as I did, that it meant deleting files older than ttl, ie the
definition of ttl...
Also, not totally sure I understand -- does that mean _only_ files older
than the ttl will be compacted, or just that if a file remains uncompacted for
longer than the ttl it will be "prematurely" compacted? I assume the latter...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
