wcarlson5 commented on a change in pull request #10634:
URL: https://github.com/apache/kafka/pull/10634#discussion_r629599232



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -1193,6 +1196,11 @@ public void updateCommittedOffsets(final TopicPartition 
topicPartition, final Lo
         committedOffsets.put(topicPartition, offset);
     }
 
+    @Override
+    public void updateEndOffsets(final TopicPartition topicPartition, final 
Long offset) {
+        highWatermark.put(topicPartition, offset);

Review comment:
       StreamThread#updateThreadMetadata does not actually update the map what 
it does is link a object reference to the map in the Task to the TaskMetadata. 
This makes it so that whenever the TaskMetadata is fetched it has the most up 
to date maps. For that to matter we need to update the map more frequently




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to