[GitHub] [kafka] showuon commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

[GitBox]

showuon commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r629990096



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##########
@@ -106,9 +104,9 @@ private boolean allSubscriptionsEqual(Set<String> allTopics,
             // initialize the subscribed topics set if this is the first 
subscription
             if (subscribedTopics.isEmpty()) {
                 subscribedTopics.addAll(subscription.topics());
-            } else if (!(subscription.topics().size() == 
subscribedTopics.size()
+            } else if (isAllSubscriptionsEqual && 
!(subscription.topics().size() == subscribedTopics.size()
                 && subscribedTopics.containsAll(subscription.topics()))) {
-                return false;
+                isAllSubscriptionsEqual = false;

Review comment:
       Now, we'll run through all the `subscriptions` since the data 
`consumerToOwnedPartitions` will also passed into `generalAssign`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org