jsancio commented on a change in pull request #10431:
URL: https://github.com/apache/kafka/pull/10431#discussion_r630367487
##########
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##########
@@ -161,19 +162,24 @@ final class KafkaMetadataLog private (
override def truncateToLatestSnapshot(): Boolean = {
val latestEpoch = log.latestEpoch.getOrElse(0)
- latestSnapshotId().asScala match {
- case Some(snapshotId) if (snapshotId.epoch > latestEpoch ||
- (snapshotId.epoch == latestEpoch && snapshotId.offset >
endOffset().offset)) =>
+ val (truncated, forgottenSnapshots) = latestSnapshotId().asScala match {
Review comment:
Synchronizing `snapshots` is only needed when accessing that object. In
`deleteBeforeSnapshot` it is grabbed because the `match` expression accesses
`snapshots` in one of the `case`/branch.
In this method I think it is safe to only grab the log where we currently do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
