ijuma commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r630556204
##########
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##########
@@ -525,6 +525,11 @@ private TransactionManager
configureTransactionState(ProducerConfig config,
final int transactionTimeoutMs =
config.getInt(ProducerConfig.TRANSACTION_TIMEOUT_CONFIG);
final long retryBackoffMs =
config.getLong(ProducerConfig.RETRY_BACKOFF_MS_CONFIG);
final boolean autoDowngradeTxnCommit =
config.getBoolean(ProducerConfig.AUTO_DOWNGRADE_TXN_COMMIT);
+ // Only log a warning if being used outside of Streams, which we
know includes "StreamThread-" in the client id
+ if (autoDowngradeTxnCommit && !clientId.contains("StreamThread-"))
{
Review comment:
@ableegoldman Your suggestion to remove the config altogether seems best
to me. We don't have a grace period for internal configs, that's why they're
internal. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
