ableegoldman commented on a change in pull request #10673:
URL: https://github.com/apache/kafka/pull/10673#discussion_r630601750
##########
File path: tests/kafkatest/services/streams.py
##########
@@ -466,6 +466,15 @@ def __init__(self, test_context, kafka, processingMode):
"org.apache.kafka.streams.tests.BrokerCompatibilityTest",
processingMode)
+ def prop_file(self):
+ properties = {streams_property.STATE_DIR: self.PERSISTENT_ROOT,
+ streams_property.KAFKA_SERVERS:
self.kafka.bootstrap_servers(),
+ # the old broker (< 2.4) does not support configuration
replication.factor=-1
+ "replication.factor": 1}
Review comment:
Sounds like we don't override the default after all? Or we have at least
one test where that slipped through 🤷‍♀️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
