ableegoldman commented on a change in pull request #10675:
URL: https://github.com/apache/kafka/pull/10675#discussion_r630614141
##########
File path:
clients/src/test/java/org/apache/kafka/clients/producer/MockProducerTest.java
##########
@@ -417,6 +417,7 @@ public void
shouldPublishConsumerGroupOffsetsOnlyAfterCommitIfTransactionsAreEna
assertEquals(Collections.singletonList(expectedResult),
producer.consumerGroupOffsetsHistory());
}
+ @SuppressWarnings("deprecation")
@Test
Review comment:
These are testing the deprecated method specifically. There is an
identical test below for the non-deprecated version of this API. Are you
suggesting we should just go ahead and remove the tests for the deprecated
functionality?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
