yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r631158775
##########
File path:
clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java
##########
@@ -106,6 +110,190 @@ public void stringSerdeShouldSupportDifferentEncodings() {
}
}
+ @SuppressWarnings("unchecked")
+ @Test
+ public void listSerdeShouldReturnEmptyCollection() {
+ List<Integer> testData = Arrays.asList();
+ Serde<List<Integer>> listSerde = Serdes.ListSerde(ArrayList.class,
Serdes.Integer());
+ assertEquals(testData,
+ listSerde.deserializer().deserialize(topic,
listSerde.serializer().serialize(topic, testData)),
+ "Should get empty collection after serialization and
deserialization on an empty list");
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void listSerdeShouldReturnNull() {
+ List<Integer> testData = null;
+ Serde<List<Integer>> listSerde = Serdes.ListSerde(ArrayList.class,
Serdes.Integer());
+ assertEquals(testData,
+ listSerde.deserializer().deserialize(topic,
listSerde.serializer().serialize(topic, testData)),
+ "Should get null after serialization and deserialization on an
empty list");
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void listSerdeShouldRoundtripIntPrimitiveInput() {
+ List<Integer> testData = Arrays.asList(1, 2, 3);
+ Serde<List<Integer>> listSerde = Serdes.ListSerde(ArrayList.class,
Serdes.Integer());
+ assertEquals(testData,
+ listSerde.deserializer().deserialize(topic,
listSerde.serializer().serialize(topic, testData)),
+ "Should get the original collection of integer primitives after
serialization and deserialization");
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void
listSerdeSerializerShouldReturnByteArrayOfFixedSizeForIntPrimitiveInput() {
+ List<Integer> testData = Arrays.asList(1, 2, 3);
+ Serde<List<Integer>> listSerde = Serdes.ListSerde(ArrayList.class,
Serdes.Integer());
+ assertEquals(21, listSerde.serializer().serialize(topic,
testData).length,
+ "Should get length of 21 bytes after serialization");
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void listSerdeShouldRoundtripShortPrimitiveInput() {
+ List<Short> testData = Arrays.asList((short) 1, (short) 2, (short) 3);
+ Serde<List<Short>> listSerde = Serdes.ListSerde(ArrayList.class,
Serdes.Short());
+ assertEquals(testData,
+ listSerde.deserializer().deserialize(topic,
listSerde.serializer().serialize(topic, testData)),
+ "Should get the original collection of short primitives after
serialization and deserialization");
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void
listSerdeSerializerShouldReturnByteArrayOfFixedSizeForShortPrimitiveInput() {
+ List<Short> testData = Arrays.asList((short) 1, (short) 2, (short) 3);
+ Serde<List<Short>> listSerde = Serdes.ListSerde(ArrayList.class,
Serdes.Short());
+ assertEquals(15, listSerde.serializer().serialize(topic,
testData).length,
+ "Should get length of 15 bytes after serialization");
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void listSerdeShouldRoundtripFloatPrimitiveInput() {
+ List<Float> testData = Arrays.asList((float) 1, (float) 2, (float) 3);
+ Serde<List<Float>> listSerde = Serdes.ListSerde(ArrayList.class,
Serdes.Float());
+ assertEquals(testData,
+ listSerde.deserializer().deserialize(topic,
listSerde.serializer().serialize(topic, testData)),
+ "Should get the original collection of float primitives after
serialization and deserialization");
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void
listSerdeSerializerShouldReturnByteArrayOfFixedSizeForFloatPrimitiveInput() {
+ List<Float> testData = Arrays.asList((float) 1, (float) 2, (float) 3);
+ Serde<List<Float>> listSerde = Serdes.ListSerde(ArrayList.class,
Serdes.Float());
+ assertEquals(21, listSerde.serializer().serialize(topic,
testData).length,
+ "Should get length of 21 bytes after serialization");
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void listSerdeShouldRoundtripLongPrimitiveInput() {
+ List<Long> testData = Arrays.asList((long) 1, (long) 2, (long) 3);
+ Serde<List<Long>> listSerde = Serdes.ListSerde(ArrayList.class,
Serdes.Long());
+ assertEquals(testData,
+ listSerde.deserializer().deserialize(topic,
listSerde.serializer().serialize(topic, testData)),
+ "Should get the original collection of long primitives after
serialization and deserialization");
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void
listSerdeSerializerShouldReturnByteArrayOfFixedSizeForLongPrimitiveInput() {
+ List<Long> testData = Arrays.asList((long) 1, (long) 2, (long) 3);
+ Serde<List<Long>> listSerde = Serdes.ListSerde(ArrayList.class,
Serdes.Long());
+ assertEquals(33, listSerde.serializer().serialize(topic,
testData).length,
+ "Should get length of 33 bytes after serialization");
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void listSerdeShouldRoundtripDoublePrimitiveInput() {
+ List<Double> testData = Arrays.asList((double) 1, (double) 2, (double)
3);
+ Serde<List<Double>> listSerde = Serdes.ListSerde(ArrayList.class,
Serdes.Double());
+ assertEquals(testData,
+ listSerde.deserializer().deserialize(topic,
listSerde.serializer().serialize(topic, testData)),
+ "Should get the original collection of double primitives after
serialization and deserialization");
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void
listSerdeSerializerShouldReturnByteArrayOfFixedSizeForDoublePrimitiveInput() {
+ List<Double> testData = Arrays.asList((double) 1, (double) 2, (double)
3);
+ Serde<List<Double>> listSerde = Serdes.ListSerde(ArrayList.class,
Serdes.Double());
+ assertEquals(33, listSerde.serializer().serialize(topic,
testData).length,
+ "Should get length of 33 bytes after serialization");
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void listSerdeShouldRoundtripUUIDInput() {
+ List<UUID> testData = Arrays.asList(UUID.randomUUID(),
UUID.randomUUID(), UUID.randomUUID());
+ Serde<List<UUID>> listSerde = Serdes.ListSerde(ArrayList.class,
Serdes.UUID());
+ assertEquals(testData,
+ listSerde.deserializer().deserialize(topic,
listSerde.serializer().serialize(topic, testData)),
+ "Should get the original collection of UUID after serialization
and deserialization");
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void
listSerdeSerializerShouldReturnByteArrayOfFixedSizeForUUIDInput() {
+ List<UUID> testData = Arrays.asList(UUID.randomUUID(),
UUID.randomUUID(), UUID.randomUUID());
+ Serde<List<UUID>> listSerde = Serdes.ListSerde(ArrayList.class,
Serdes.UUID());
+ assertEquals(117, listSerde.serializer().serialize(topic,
testData).length,
+ "Should get length of 117 bytes after serialization");
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void listSerdeShouldRoundtripNonPrimitiveInput() {
+ List<String> testData = Arrays.asList("A", "B", "C");
+ Serde<List<String>> listSerde = Serdes.ListSerde(ArrayList.class,
Serdes.String());
+ assertEquals(testData,
+ listSerde.deserializer().deserialize(topic,
listSerde.serializer().serialize(topic, testData)),
+ "Should get the original collection of strings list after
serialization and deserialization");
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void listSerdeShouldRoundtripPrimitiveInputWithNullEntries() {
+ List<Integer> testData = Arrays.asList(1, null, 3);
+ Serde<List<Integer>> listSerde = Serdes.ListSerde(ArrayList.class,
Serdes.Integer());
+ assertEquals(testData,
+ listSerde.deserializer().deserialize(topic,
listSerde.serializer().serialize(topic, testData)),
+ "Should get the original collection of integer primitives with
null entries "
+ + "after serialization and deserialization");
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void listSerdeShouldRoundtripNonPrimitiveInputWithNullEntries() {
+ List<String> testData = Arrays.asList("A", null, "C");
+ Serde<List<String>> listSerde = Serdes.ListSerde(ArrayList.class,
Serdes.String());
+ assertEquals(testData,
+ listSerde.deserializer().deserialize(topic,
listSerde.serializer().serialize(topic, testData)),
+ "Should get the original collection of strings list with null
entries "
+ + "after serialization and deserialization");
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void listSerdeShouldReturnLinkedList() {
+ List<Integer> testData = new LinkedList<>();
+ Serde<List<Integer>> listSerde = Serdes.ListSerde(LinkedList.class,
Serdes.Integer());
+ assertTrue(listSerde.deserializer().deserialize(topic,
listSerde.serializer().serialize(topic, testData))
+ instanceof LinkedList, "Should return List instance of type
LinkedList");
+ }
+
+ @SuppressWarnings("unchecked")
Review comment:
No, unfortunately they are still needed.
AFAIK, suppression warnings cannot be propagated upwards.
In `ListDeserializer#createListInstance` we indeed using
`SuppressWarnings("unchecked")` due to casting.
However, in tests it is used bc `Stack.class` (or `ArrayList.class`,
`LinkedList.class`, etc) is a raw-type and does not guarantee the required
inner type (`Integer` in this case).
The only way to deal with these warnings is to create some wrapper classes
as @mjsax suggested, like:
`public static class IntegerArrayList extends ArrayList<Integer> {}`
But I do not this it is a scalable and clean solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
