[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

[GitBox]

kowshik commented on a change in pull request #10684:
URL: https://github.com/apache/kafka/pull/10684#discussion_r631584810



##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -1204,13 +1202,12 @@ class Log(@volatile private var _dir: File,
         // Do the read on the segment with a base offset less than the target 
offset
         // but if that segment doesn't contain any messages with an offset 
greater than that
         // continue to read from successive segments until we get some 
messages or we reach the end of the log
-        var done = segmentEntryOpt.isEmpty
+        var done = segmentOpt.isEmpty
         var fetchDataInfo: FetchDataInfo = null
+        val segmentsIterator = segmentOpt.map(segment => 
segments.higherSegments(segment.baseOffset))

Review comment:
       Done, made it private. Please see 
80c40171302546be2dcf2444167d7f375f0b820d.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org