wcarlson5 commented on a change in pull request #10609:
URL: https://github.com/apache/kafka/pull/10609#discussion_r631965080
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##########
@@ -2035,6 +2035,11 @@ private void updateSubscribedTopics(final Set<String>
topics, final String logPr
return maybeDecorateInternalSourceTopics(sourceTopicNames);
}
+ public boolean hasNamedTopologies() {
+ // TODO
Review comment:
I am assuming that this will be done in a later PR
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java
##########
@@ -59,8 +58,8 @@ public TaskId(final int topicGroupId, final int partition,
final String namedTop
}
}
- public Optional<String> namedTopology() {
- return namedTopology == null ? Optional.empty() :
Optional.of(namedTopology);
+ public String namedTopology() {
Review comment:
Are we going to to just make all subtopologies named ?
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StateDirectoryTest.java
##########
@@ -372,29 +356,25 @@ public void
shouldReturnEmptyArrayIfListFilesReturnsNull() throws IOException {
assertTrue(appDir.createNewFile());
assertTrue(appDir.exists());
assertNull(appDir.listFiles());
- assertEquals(0, directory.listAllTaskDirectories().length);
+ assertEquals(0, directory.listAllTaskDirectories().size());
}
@Test
public void shouldOnlyListNonEmptyTaskDirectories() throws IOException {
TestUtils.tempDirectory(stateDir.toPath(), "foo");
- final File taskDir1 = directory.getOrCreateDirectoryForTask(new
TaskId(0, 0));
- final File taskDir2 = directory.getOrCreateDirectoryForTask(new
TaskId(0, 1));
+ final TaskDirectory taskDir1 = new
TaskDirectory(directory.getOrCreateDirectoryForTask(new TaskId(0, 0)), null);
Review comment:
I think I saw a comment about updating these with named topologies
later. Is there are reason you are waiting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
