cmccabe commented on a change in pull request #10688:
URL: https://github.com/apache/kafka/pull/10688#discussion_r632695450
##########
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##########
@@ -1030,17 +1050,24 @@ private QuorumController(LogContext logContext,
@Override
public CompletableFuture<AlterPartitionReassignmentsResponseData>
alterPartitionReassignments(AlterPartitionReassignmentsRequestData
request) {
- CompletableFuture<AlterPartitionReassignmentsResponseData> future =
new CompletableFuture<>();
- future.completeExceptionally(new UnsupportedOperationException());
- return future;
+ if (request.topics().isEmpty()) {
+ return CompletableFuture.completedFuture(new
AlterPartitionReassignmentsResponseData());
+ }
+ return appendWriteEvent("alterPartitionReassignments",
+ time.nanoseconds() + NANOSECONDS.convert(request.timeoutMs(),
MILLISECONDS),
+ () -> {
+ throw new UnsupportedOperationException();
+ });
}
@Override
public CompletableFuture<ListPartitionReassignmentsResponseData>
listPartitionReassignments(ListPartitionReassignmentsRequestData
request) {
- CompletableFuture<ListPartitionReassignmentsResponseData> future = new
CompletableFuture<>();
- future.completeExceptionally(new UnsupportedOperationException());
- return future;
+ return appendReadEvent("listPartitionReassignments",
+ time.nanoseconds() + NANOSECONDS.convert(request.timeoutMs(),
MILLISECONDS),
+ () -> {
+ throw new UnsupportedOperationException();
+ });
Review comment:
agreed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
