ableegoldman commented on a change in pull request #10690:
URL: https://github.com/apache/kafka/pull/10690#discussion_r632787843



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##########
@@ -201,7 +201,8 @@
     public static final String MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION = 
"max.in.flight.requests.per.connection";
     private static final String MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION_DOC = 
"The maximum number of unacknowledged requests the client will send on a single 
connection before blocking."
                                                                             + 
" Note that if this setting is set to be greater than 1 and there are failed 
sends, there is a risk of"
-                                                                            + 
" message re-ordering due to retries (i.e., if retries are enabled).";
+                                                                            + 
" message re-ordering due to retries (i.e., if retries are enabled). With an 
idempotent producer, this"
+                                                                            + 
" can be up to 5 and still provide ordering guarantees.";

Review comment:
       @ijuma done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to